Skip to content

[WIP]added the latest .whl files for the license_expression(Part of the issue:adding License Expression to DeltaCode) - #147

Closed
pratik0316 wants to merge 5 commits into
aboutcode-org:developfrom
pratik0316:integratingLicenseExp
Closed

pratik0316 wants to merge 5 commits into
aboutcode-org:developfrom
pratik0316:integratingLicenseExp

Conversation

@pratik0316

Copy link
Copy Markdown
Collaborator

In this PR I changed the thirdparty packages by inserting new .whl packages for license_expression(version:1.2,old version 0.99)

Signed-off-by: Pratikrocks <pratikrocks.dey11@gmail.com>
@pratik0316
pratik0316 force-pushed the integratingLicenseExp branch from b84b0b7 to 2ecf3b1 Compare March 21, 2020 14:22
@pratik0316

pratik0316 commented Mar 21, 2020

Copy link
Copy Markdown
Collaborator Author

@MaJuRG this PR is meant to update the TPP to have the latest license_expression library.Regarding the integration of this library I have a few queries:
I was testing the functionalities of license_expression
It had the options to :
is_equivalent : for testing two expressions
parse:for parsing a library exp
contains:for checking weather an exp is contained in another
and many more
But in DeltaCode currently we are currently dealing with mainly files(and its status), if any license is present in a file it takes the additional info from it (like owner, category) in a string expression for each deltas.
So for what purpose(s), can we eventually make use of this library?

@steven-esser

Copy link
Copy Markdown
Contributor

@Pratikrocks the license_expression library has the ability to simplify() a complex expression down to its base license_key (and category) elements.

Since we are only using string comparison on license_expression values ATM, we will want to be able to compare complex expressions and their categories and score them appropriately.

For example, currently when we compare mit OR bsd-new OR mit with mit OR bsd-new, this would fail currently. With the license expression library, we would be able to compare these correctly.

@pratik0316

Copy link
Copy Markdown
Collaborator Author

Okay so basically we are going to deal here with deltas having multiple licenses and going to tokenize it down.

@steven-esser

Copy link
Copy Markdown
Contributor

yes

@pratik0316 pratik0316 changed the title added the latest .whl files for the license_expression(Part of the issue:adding License Expression to DeltaCode) [WIP]added the latest .whl files for the license_expression(Part of the issue:adding License Expression to DeltaCode) Apr 23, 2020
Signed-off-by: Pratikrocks <pratikrocks.dey11@gmail.com>
… for Py3)

Signed-off-by: Pratikrocks <pratikrocks.dey11@gmail.com>
Signed-off-by: Pratikrocks <pratikrocks.dey11@gmail.com>
Signed-off-by: Pratikrocks <pratikrocks.dey11@gmail.com>
@steven-esser

Copy link
Copy Markdown
Contributor

Closing due to stagnation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants